Skip to content

Add vm_error field for transactions in Block Replay #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add vm_error field for transactions in Block Replay #6575

wants to merge 1 commit into from

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Oct 8, 2025 •
edited
Loading

Description

This patch improves the Block Replay endpoint by allowing it to returns the specific vm_error of a failed transaction.

A new test has been added and the TestRPC framework has been improved for allowing the addition of custom transactions in the tip block.

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris marked this pull request as ready for review October 8, 2025 12:10
@rdeioris rdeioris requested review from a team as code owners October 8, 2025 12:10
@rdeioris rdeioris requested review from jcnelson and obycode October 8, 2025 13:16
@janniks
Copy link
Contributor

janniks commented Oct 8, 2025

Awesome! So we can assume any time there is a non-null vm-error string something went wrong, in my case we don't really care what went wrong, but can use the presence as a general failed indicator?

@rdeioris
Copy link
Contributor Author

rdeioris commented Oct 8, 2025

Awesome! So we can assume any time there is a non-null vm-error string something went wrong, in my case we don't really care what went wrong, but can use the presence as a general failed indicator?

Correct, the presence of vm_error signals a runtime error

obycode
obycode approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obycode obycode obycode approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rdeioris @janniks @obycode